Do not timeout when calling HF through acomplete #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
lgtm! thanks for the fix @okotek |
|
@okotek curious - what're you using async hf completions for? context - trying to improve our own implementation, and want to make sure we're good for your scenario. |
|
Over here https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/algo/ai_handler.py I've been running HF TGI on a GPU server and tried to connect to it. |
|
got it - 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use litellm for a HF text-generation-inference server. When using completion everything works as expected. When using acompletion, a timeout exception occurs after 5 seconds.
This PR changes the default timeout of httpx to None.