Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main.py): fix key leak error when unknown provider given #8556

Merged
merged 5 commits into from
Feb 15, 2025

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Feb 15, 2025

  • fix(main.py): fix key leak error when unknown provider given

don't return passed in args if unknown route on embedding

  • fix(main.py): remove instances of {args} being passed in exception

prevent potential key leaks

  • test(code_coverage/prevent_key_leaks_in_codebase.py): ban usage of {args} in codebase

  • fix: fix linting errors

  • fix: remove unused variable

don't return passed in args if unknown route on embedding
Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 4:19pm

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
litellm/main.py 16.66% 5 Missing ⚠️
litellm/exceptions.py 57.14% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@krrishdholakia krrishdholakia merged commit a9276f2 into main Feb 15, 2025
35 of 36 checks passed
abhijitherekar pushed a commit to acuvity/litellm that referenced this pull request Feb 20, 2025
…#8556)

* fix(main.py): fix key leak error when unknown provider given

don't return passed in args if unknown route on embedding

* fix(main.py): remove instances of {args} being passed in exception

prevent potential key leaks

* test(code_coverage/prevent_key_leaks_in_codebase.py): ban usage of {args} in codebase

* fix: fix linting errors

* fix: remove unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant