Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rpm check on keys #8301

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Improve rpm check on keys #8301

merged 5 commits into from
Feb 6, 2025

Conversation

krrishdholakia
Copy link
Contributor

Title

Improve rpm check on keys

Relevant issues

Resolves #6938

Type

🐛 Bug Fix

Changes

  • move rpm increment to pre call hook
  • refactor key / model limits by key to use common _check_key_in_limits function

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Covered by existing testing in test_parallel_request_limiter.py

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:40am

@krrishdholakia krrishdholakia merged commit b4e5c0d into main Feb 6, 2025
32 of 33 checks passed
@krrishdholakia krrishdholakia deleted the litellm_dev_02_05_2025_p3 branch February 6, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RPM limit for key is not working as expected
1 participant