Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal User Endpoint - vulnerability fix + response type fix #8228

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Feb 4, 2025

Title

  • fix(key_management_endpoints.py): fix vulnerability where a user could update another user's keys
  • fix(internal_user_endpoints.py): return model max budget in internal user create response

Relevant issues

Resolves #8031
Fixes #7047

Type

🐛 Bug Fix
✅ Test

Changes

  • adds a common key access check across /key/generate + /key/update
  • adds unit testing for isolated user changes across update + delete endpoints
  • updates new user response dictionary - return model_max_budget

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 6:45am

…ror when modifying key that doesn't belong to user
@krrishdholakia krrishdholakia changed the title fix(key_management_endpoints.py): fix vulnerability where a user coul… Internal User Endpoint - vulnerability fix + response type fix Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...y/management_endpoints/key_management_endpoints.py 61.53% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@krrishdholakia krrishdholakia merged commit df93deb into main Feb 4, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants