Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router.get_available_deployment: Handle empty input edge case #729

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Router.get_available_deployment: Handle empty input edge case #729

merged 1 commit into from
Oct 31, 2023

Conversation

mc-marcocheng
Copy link
Contributor

@mc-marcocheng mc-marcocheng commented Oct 31, 2023 •
edited
Loading

If boolean of the input and messages evaluates to False, it errors out:

   if current_tpm + token_count > tpm or current_rpm + 1 >= rpm:
UnboundLocalError: local variable 'token_count' referenced before assignment

@vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 6:44am

@krrishdholakia
Copy link
Contributor

lgtm

@krrishdholakia krrishdholakia merged commit 730fd28 into BerriAI:main Oct 31, 2023
@TMFRook TMFRook mentioned this pull request Apr 4, 2024
Open
@Bidaya0 Bidaya0 mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mc-marcocheng @krrishdholakia