Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Alpine Dockerfile by removing redundant apk commands #5016

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

PeterDaveHello
Copy link
Contributor

Title

Optimize Alpine Dockerfile by removing redundant apk commands

Type

🧹 Refactoring

Changes

Remove unnecessary apk update and manual cache cleanup steps in the Alpine Dockerfile. By using apk add --no-cache, we avoid manual cache management, making the Dockerfile simpler and easier to maintain.

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

I successfully built the Docker image:

REPOSITORY                   TAG                  IMAGE ID       CREATED         SIZE
litellm-dockerfile           apk-cache-optimiza   ca617f454c3e   21 hours ago    1.46GB

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 4:28pm

@PeterDaveHello
Copy link
Contributor Author

Hi @ishaan-jaff @krrishdholakia Should we proceed with completing this PR? Thanks.

@PeterDaveHello
Copy link
Contributor Author

@ishaan-jaff @krrishdholakia please let me know if you'd like me to resolve the conflict and make you a better Dockerfile ;)

@krrishdholakia
Copy link
Contributor

Sure let's do that

Remove unnecessary `apk update` and manual cache cleanup steps in the
Alpine Dockerfile. By using `apk add --no-cache`, we avoid manual cache
management, making the Dockerfile simpler and easier to maintain.
@PeterDaveHello
Copy link
Contributor Author

Thanks, @krrishdholakia! It's all done. I would be happy to help improve it further after this one if you'd like. Just let me know if everything looks good to go.

@krrishdholakia krrishdholakia merged commit c6026ea into BerriAI:main Feb 15, 2025
2 checks passed
@krrishdholakia
Copy link
Contributor

Sure - any improvements are welcome.

For the next pr - if you can attach a screenshot / some proof of it working, that would help accelerate the review on our end!

@PeterDaveHello PeterDaveHello deleted the Dockerfile branch February 15, 2025 17:01
@PeterDaveHello
Copy link
Contributor Author

Sure - any improvements are welcome.

For the next pr - if you can attach a screenshot / some proof of it working, that would help accelerate the review on our end!

A successful Docker image result was attached in the first comment, let me know if you need something specified other than that ;)

@krrishdholakia
Copy link
Contributor

Missed that, thanks! @PeterDaveHello

abhijitherekar pushed a commit to acuvity/litellm that referenced this pull request Feb 20, 2025
…I#5016)

Remove unnecessary `apk update` and manual cache cleanup steps in the
Alpine Dockerfile. By using `apk add --no-cache`, we avoid manual cache
management, making the Dockerfile simpler and easier to maintain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants