-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Alpine Dockerfile by removing redundant apk commands #5016
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @ishaan-jaff @krrishdholakia Should we proceed with completing this PR? Thanks. |
@ishaan-jaff @krrishdholakia please let me know if you'd like me to resolve the conflict and make you a better Dockerfile ;) |
Sure let's do that |
Remove unnecessary `apk update` and manual cache cleanup steps in the Alpine Dockerfile. By using `apk add --no-cache`, we avoid manual cache management, making the Dockerfile simpler and easier to maintain.
daf43e2
to
62b308e
Compare
Thanks, @krrishdholakia! It's all done. I would be happy to help improve it further after this one if you'd like. Just let me know if everything looks good to go. |
Sure - any improvements are welcome. For the next pr - if you can attach a screenshot / some proof of it working, that would help accelerate the review on our end! |
A successful Docker image result was attached in the first comment, let me know if you need something specified other than that ;) |
Missed that, thanks! @PeterDaveHello |
…I#5016) Remove unnecessary `apk update` and manual cache cleanup steps in the Alpine Dockerfile. By using `apk add --no-cache`, we avoid manual cache management, making the Dockerfile simpler and easier to maintain.
Title
Optimize Alpine Dockerfile by removing redundant apk commands
Type
🧹 Refactoring
Changes
Remove unnecessary
apk update
and manual cache cleanup steps in the Alpine Dockerfile. By usingapk add --no-cache
, we avoid manual cache management, making the Dockerfile simpler and easier to maintain.[REQUIRED] Testing - Attach a screenshot of any new tests passing locall
If UI changes, send a screenshot/GIF of working UI fixes
I successfully built the Docker image: