Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify user email created via /user/new #1759

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

scampion
Copy link
Contributor

@scampion scampion commented Feb 2, 2024

When you synchronize your current org IAM, it's useful to push also the email since it's standardized compare to user_id

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 10:12am
litellm-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 10:12am

@krrishdholakia
Copy link
Contributor

krrishdholakia commented Feb 2, 2024

This will require db schema changes as well. I can pick up this ticket @scampion

We were initially treating user_id as the place you'd put the email. This is good feedback.

Can we get on a call? I want to understand how you're using the proxy + this feature

https://calendly.com/d/4mp-gd3-k5k/litellm-1-1-onboarding-chat

@ishaan-jaff
Copy link
Contributor

@scampion
Copy link
Contributor Author

scampion commented Feb 2, 2024

Indeed, I test it and it works for me

@krrishdholakia
Copy link
Contributor

you're right @ishaan-jaff, seems like we were just missing it in docs. LGTM

@krrishdholakia krrishdholakia merged commit 8b2314e into BerriAI:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants