Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make grid a resource #67

Merged
merged 11 commits into from
Oct 28, 2023
Merged

Make grid a resource #67

merged 11 commits into from
Oct 28, 2023

Conversation

BenjaTK
Copy link
Owner

@BenjaTK BenjaTK commented Oct 26, 2023 •
edited
Loading

Makes the grid a resource instead of a dictionary as explained in #65
Closes #65

This also includes a few changes:

  • Vector2 and Vector3 have been changed to their integer variant in the grid.
  • Modifier's apply functions no longer return the new grid, they just modify the resource.
  • Things like tile_pos or get_tile have been changed to cell for consistency.

TODO:

  • Change 3D generators to work with this new resource

@BenjaTK BenjaTK added ✨ enhancement New feature or request 🛠 breaking A change that could break already existing projects. labels Oct 26, 2023
@BenjaTK BenjaTK changed the title Make grid a resource Make grid a resource and change Vectors to their int variants Oct 26, 2023
@BenjaTK BenjaTK marked this pull request as ready for review October 26, 2023 21:33
@BenjaTK BenjaTK changed the title Make grid a resource and change Vectors to their int variants Make grid a resource Oct 26, 2023
chendrak
chendrak approved these changes Oct 28, 2023
View reviewed changes
addons/gaea/grid.gd Show resolved Hide resolved
addons/gaea/grid.gd Show resolved Hide resolved
@BenjaTK
Copy link
Owner Author

BenjaTK commented Oct 28, 2023

Merging

@BenjaTK BenjaTK merged commit f9902ca into main Oct 28, 2023
@BenjaTK BenjaTK deleted the grid-resource branch October 28, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendrak chendrak chendrak approved these changes

Assignees
No one assigned
Labels
🛠 breaking A change that could break already existing projects. ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make grid a resource
2 participants
@BenjaTK @chendrak