4.7.1 release, reducing allocations in main loop

BenMakesGames · May 28, 2024 · 5859d24 · 5859d24
1 parent 7ee4533
commit 5859d24
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 14 deletions.
diff --git a/BenMakesGames.PlayPlayMini.BeepBoop/BenMakesGames.PlayPlayMini.BeepBoop.csproj b/BenMakesGames.PlayPlayMini.BeepBoop/BenMakesGames.PlayPlayMini.BeepBoop.csproj
@@ -5,7 +5,7 @@
         <Company>Ben Hendel-Doying</Company>
         <Description>An extension for PlayPlayMini which adds methods for generating &amp; playing simple waveforms.</Description>
         <Copyright>2022-2023 Ben Hendel-Doying</Copyright>
-        <Version>0.5.0</Version>
+        <Version>0.5.1</Version>
 
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageTags>monogame playplaymini sound generation square triangle saw sine wave waveform</PackageTags>

diff --git a/...ames.PlayPlayMini.GraphicsExtensions/BenMakesGames.PlayPlayMini.GraphicsExtensions.csproj b/...ames.PlayPlayMini.GraphicsExtensions/BenMakesGames.PlayPlayMini.GraphicsExtensions.csproj
@@ -5,7 +5,7 @@
         <Company>Ben Hendel-Doying</Company>
         <Description>Some GraphicsManager extensions for PlayPlayMini.</Description>
         <Copyright>2023-2024 Ben Hendel-Doying</Copyright>
-        <Version>4.7.0</Version>
+        <Version>4.7.1</Version>
 
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageTags>monogame playplaymini graphics extensions animations text</PackageTags>

diff --git a/BenMakesGames.PlayPlayMini.NAudio/BenMakesGames.PlayPlayMini.NAudio.csproj b/BenMakesGames.PlayPlayMini.NAudio/BenMakesGames.PlayPlayMini.NAudio.csproj
@@ -5,7 +5,7 @@
         <Company>Ben Hendel-Doying</Company>
         <Description>Get seamless looping music, and cross-fade, in your MonoGame-PlayPlayMini game using NAudio.</Description>
         <Copyright>2024 Ben Hendel-Doying</Copyright>
-        <Version>0.3.0</Version>
+        <Version>0.3.1</Version>
 
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageTags>monogame playplaymini naudio music</PackageTags>

diff --git a/BenMakesGames.PlayPlayMini.UI/BenMakesGames.PlayPlayMini.UI.csproj b/BenMakesGames.PlayPlayMini.UI/BenMakesGames.PlayPlayMini.UI.csproj
@@ -5,7 +5,7 @@
     <Company>Ben Hendel-Doying</Company>
     <Description>An extension for PlayPlayMini, adding a skinnable, object-oriented UI framework.</Description>
     <Copyright>2021-2024 Ben Hendel-Doying</Copyright>
-    <Version>4.7.0</Version>
+    <Version>4.7.1</Version>
 
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageTags>monogame mouse ui framework oo</PackageTags>

diff --git a/BenMakesGames.PlayPlayMini/BenMakesGames.PlayPlayMini.csproj b/BenMakesGames.PlayPlayMini/BenMakesGames.PlayPlayMini.csproj
@@ -5,7 +5,7 @@
     <Company>Ben Hendel-Doying</Company>
     <Description>An opinionated framework for making smallish games with MonoGame.</Description>
     <Copyright>2021-2024 Ben Hendel-Doying</Copyright>
-    <Version>4.7.0</Version>
+    <Version>4.7.1</Version>
 
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageTags>monogame game engine framework di state</PackageTags>

diff --git a/BenMakesGames.PlayPlayMini/GameStateManager.cs b/BenMakesGames.PlayPlayMini/GameStateManager.cs
@@ -81,8 +81,10 @@ protected override void Initialize()
 
     private void Input(GameTime gameTime)
     {
-        foreach(var s in ServiceWatcher.InputServices)
-            s.Input(gameTime);
+        // ReSharper disable once ForCanBeConvertedToForeach
+        // for loop, instead of foreach, reduces allocations
+        for(var i = 0; i < ServiceWatcher.InputServices.Count; i++)
+            ServiceWatcher.InputServices[i].Input(gameTime);
 
         CurrentState.Input(gameTime);
     }
@@ -106,8 +108,10 @@ protected override void Update(GameTime gameTime)
 
         base.Update(gameTime);
 
-        foreach (var s in ServiceWatcher.UpdatedServices)
-            s.Update(gameTime);
+        // ReSharper disable once ForCanBeConvertedToForeach
+        // for loop, instead of foreach, reduces allocations
+        for (var i = 0; i < ServiceWatcher.UpdatedServices.Count; i++)
+            ServiceWatcher.UpdatedServices[i].Update(gameTime);
 
         FixedUpdateAccumulator += gameTime.ElapsedGameTime.TotalMilliseconds;
 

diff --git a/BenMakesGames.PlayPlayMini/Services/ServiceWatcher.cs b/BenMakesGames.PlayPlayMini/Services/ServiceWatcher.cs
@@ -10,11 +10,11 @@ public sealed class ServiceWatcher
     private List<IServiceUpdate> ServicesWithUpdateEvents { get; } = new();
     private List<IServiceDraw> ServicesWithDrawEvents { get; } = new();
 
-    public IReadOnlyCollection<IServiceLoadContent> ContentLoadingServices => ServiceWithLoadContentEvents;
-    public IReadOnlyCollection<IServiceInitialize> InitializedServices => ServicesWithInitializeEvents;
-    public IReadOnlyCollection<IServiceInput> InputServices => ServicesWithInputEvents;
-    public IReadOnlyCollection<IServiceUpdate> UpdatedServices => ServicesWithUpdateEvents;
-    public IReadOnlyCollection<IServiceDraw> DrawnServices => ServicesWithDrawEvents;
+    public IReadOnlyList<IServiceLoadContent> ContentLoadingServices => ServiceWithLoadContentEvents;
+    public IReadOnlyList<IServiceInitialize> InitializedServices => ServicesWithInitializeEvents;
+    public IReadOnlyList<IServiceInput> InputServices => ServicesWithInputEvents;
+    public IReadOnlyList<IServiceUpdate> UpdatedServices => ServicesWithUpdateEvents;
+    public IReadOnlyList<IServiceDraw> DrawnServices => ServicesWithDrawEvents;
 
     public void RegisterService(object service)
     {