Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove posix import #250

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Remove posix import #250

merged 1 commit into from
Dec 31, 2022

Conversation

Belval
Copy link
Owner

@Belval Belval commented Dec 31, 2022

Fixes: #249

Unused imported was added in 1.16.1. Also need to pull the release and remove the version from PyPI.

Will need to investigate why the CI didn't raise and issue.

@codecov-commenter
Copy link

Codecov Report

Base: 96.09% // Head: 96.07% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (233bb08) compared to base (34d3461).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   96.09%   96.07%   -0.02%     
==========================================
  Files           5        5              
  Lines         307      306       -1     
==========================================
- Hits          295      294       -1     
  Misses         12       12              
Impacted Files Coverage Δ
pdf2image/pdf2image.py 95.31% <ø> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Belval
Copy link
Owner Author

Belval commented Dec 31, 2022

Tested on Windows, there are still two tests failing:

tests.py::PDFConversionMethods::test_conversion_from_pathlib_path_using_dir
tests.py::PDFConversionMethods::test_conversion_from_pathlib_path_using_dir_14

I will be opening an issue but I think in the meantime this is good to go.

@Belval Belval merged commit 1c34189 into master Dec 31, 2022
@Belval Belval deleted the fix-posix-import branch December 31, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf2image 1.16.1: Import error on Windows: No module named 'posix'
2 participants