Fixes Cycling audio device

Wrong device was used. Fixes #93
Belphemur · May 1, 2016 · 4f6e67b · 4f6e67b
1 parent 978b1f4
commit 4f6e67b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/SoundSwitch.Tests/PlaybackDevices.cs b/SoundSwitch.Tests/PlaybackDevices.cs
@@ -194,8 +194,8 @@ public void TestCycleConsoleAudioDevice()
             audioMoqI.VerifyGet(a => a.Id);
             audioMoqII.VerifyGet(a => a.Id);
             listerMoq.Verify(l => l.GetPlaybackDevices());
-            audioMoqII.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.Console)));
-            audioMoqII.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.Multimedia)));
+            audioMoqI.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.Console)));
+            audioMoqI.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.Multimedia)));
         }
 
         [Test]
@@ -234,7 +234,7 @@ public void TestCycleCommunicationsAudioDevice()
             audioMoqI.VerifyGet(a => a.Id);
             audioMoqII.VerifyGet(a => a.Id);
             listerMoq.Verify(l => l.GetPlaybackDevices());
-            audioMoqI.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.All)));
+            audioMoqII.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.All)));
         }
 
         [Test]

diff --git a/SoundSwitch.Tests/RecordingDevices.cs b/SoundSwitch.Tests/RecordingDevices.cs
@@ -235,7 +235,7 @@ public void TestCycleCommunicationsAudioDevice()
             audioMoqI.VerifyGet(a => a.Id);
             audioMoqII.VerifyGet(a => a.Id);
             listerMoq.Verify(l => l.GetRecordingDevices());
-            audioMoqII.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.All)));
+            audioMoqI.Verify(a => a.SetAsDefault(It.Is<Role>(role => role == Role.All)));
         }
 
         [Test]

diff --git a/SoundSwitch/Framework/DeviceCyclerManager/DeviceCycler/ADeviceCycler.cs b/SoundSwitch/Framework/DeviceCyclerManager/DeviceCycler/ADeviceCycler.cs
@@ -24,17 +24,13 @@ public abstract class ADeviceCycler : IDeviceCycler
         /// </summary>
         /// <param name="audioDevices"></param>
         /// <param name="type"></param>
-        /// <param name="lastDevice"></param>
         /// <returns></returns>
         protected IAudioDevice GetNextDevice(ICollection<IAudioDevice> audioDevices, AudioDeviceType type)
         {
             IAudioDevice lastDevice;
-            if (!_lastDevices.TryGetValue(type, out lastDevice))
-            {
-                return audioDevices.First();
-            }
+            _lastDevices.TryGetValue(type, out lastDevice);
 
-            var defaultDev = audioDevices.FirstOrDefault(device => device.Id == lastDevice.Id) ??
+            var defaultDev = lastDevice ??
                              audioDevices.FirstOrDefault(device => device.IsDefault(Role.Console)) ??
                              audioDevices.Last();
             var next = audioDevices.SkipWhile((device, i) => !Equals(device, defaultDev)).Skip(1).FirstOrDefault() ??