boost(volume): Keep volume includes both playback and recording devices

Belphemur · Mar 1, 2024 · 03d1aa8 · 03d1aa8
1 parent 8ef416b
commit 03d1aa8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/SoundSwitch.Audio.Manager/AudioSwitcher.cs b/SoundSwitch.Audio.Manager/AudioSwitcher.cs
@@ -177,12 +177,6 @@ public void SwitchForegroundProcessTo(string deviceId, ERole role, EDataFlow flo
             SwitchProcessTo(deviceId, role, flow, processId);
         }
 
-        /// <summary>
-        /// Set the same master volume level from the default audio device to the next device
-        /// </summary>
-        /// <param name="deviceId">Id of the device</param>
-        /// <param name="role">Which role to switch</param>
-        /// <param name="flow">Which flow to switch</param>
         /// <summary>
         /// Get the current default endpoint
         /// </summary>

diff --git a/SoundSwitch/Framework/DeviceCyclerManager/DeviceCycler/ADeviceCycler.cs b/SoundSwitch/Framework/DeviceCyclerManager/DeviceCycler/ADeviceCycler.cs
@@ -79,7 +79,7 @@ private DeviceInfo GetNextDevice(DeviceInfo[] audioDevices, DataFlow type)
         /// <param name="device"></param>
         public bool SetActiveDevice(DeviceInfo device)
         {
-            if (device.Type != DataFlow.Capture && AppModel.Instance.KeepVolumeEnabled)
+            if (AppModel.Instance.KeepVolumeEnabled)
             {
                 AudioSwitcher.Instance.SetVolumeFromDefaultDevice(device);
             }

diff --git a/SoundSwitch/Localization/SettingsStrings.Designer.cs b/SoundSwitch/Localization/SettingsStrings.Designer.cs
diff --git a/SoundSwitch/Localization/SettingsStrings.resx b/SoundSwitch/Localization/SettingsStrings.resx
@@ -242,7 +242,7 @@ Banner: Uses a custom always-on-top frame, useful for in-game usage.</value>
     <value>Recording Device</value>
   </data>
   <data name="tooltipOnHoverOptionBothDevices" xml:space="preserve">
-    <value>For both Devices</value>
+    <value>Both Devices</value>
   </data>
   <data name="audioFileNotFound" xml:space="preserve">
     <value>The audio file you selected to be used as notification can't be found. SoundSwitch switched the notification setting back to {0}.</value>
@@ -487,7 +487,7 @@ Restore the state of the system when the application is closed.</value>
     <value>Keep volume level across devices</value>
   </data>
   <data name="keepVolume.desc" xml:space="preserve">
-    <value>Keep the same volume level when switching playback devices</value>
+    <value>Keep the same volume level when switching devices</value>
   </data>
   <data name="devices.AutoAddNewDevice" xml:space="preserve">
     <value>Auto select new devices</value>