Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ready to run from school Linux #59

Conversation

linhtng
Copy link
Contributor

@linhtng linhtng commented Aug 18, 2024

@pixelsnow @wengcychan @djames9
Main changes:

  • Adapt ALLOWED_HOSTS and CSRF_TRUSTED_ORIGINS in backend settings
  • Add NGINX_PORT to .env file
  • In the codebase, replace the hard-coded NGINX_PORT by the one fetched from .env file as much as possible. There are still 2 places in which it is still hard-coded, which is in nginx.conf file. It looks troublesome to set up script for that so I just leave it be.

Testing:
Run make with the newest .env and see that everything works.

@linhtng linhtng requested a review from liocle August 18, 2024 13:36
@liocle
Copy link
Collaborator

liocle commented Aug 22, 2024

Looks good to me! : ) I have tested to access nginx with the port in the .env file, both localhost and the loopback address were accessible. Please someone else who may be more knowledgeable in Python check the code as well: @pixelsnow @wengcychan @djames9 ?

@linhtng
Copy link
Contributor Author

linhtng commented Aug 30, 2024

As I learnt from @liocle that we can eval from cluster 4 on computers where port 443 works, this PR is no longer needed.

@linhtng linhtng closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the project settings for our beePong to run on cluster PC (linux)
2 participants