[Visual Editor] Fix a race condition between update AST and save change events #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and saving the changes made on the template. Since we have 2 distinct events: one to update the AST and another to actually save the changes, on an env with high latency when one makes a change on the visual editor and hit Save Change there could a race condition that would save the old template because it wasn't updated yet. So we need to use another assign that is guaranteed to be updated before the save event actually happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition between updating the AST from client/server and saving the changes made on the template.
Since we have 2 distinct events: one to update the AST and another to actually save the changes, on an env with high latency when one makes a change on the visual editor and hit Save Change there could a race condition that would save the old template because it wasn't updated yet.
So we need to use another assign that is guaranteed to be updated before the save event actually happens.
Close #226