Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Light colored Theme #56

Closed
GrazianoCapelli opened this issue Aug 25, 2018 · 6 comments
Closed

Add a Light colored Theme #56

GrazianoCapelli opened this issue Aug 25, 2018 · 6 comments
Assignees
Labels
feature This is / would be a new feature for the App

Comments

@GrazianoCapelli
Copy link
Member

GrazianoCapelli commented Aug 25, 2018

A dark theme is a Nightmare to use on bright Environments.
I propose to implement a light Theme to improve the readability in these conditions.
The user should have the possibility to switch between light and dark Theme during the usage.

We should start here with a UI mockup.

@GrazianoCapelli GrazianoCapelli added the feature This is / would be a new feature for the App label Aug 25, 2018
@GrazianoCapelli GrazianoCapelli self-assigned this Dec 27, 2019
@GrazianoCapelli
Copy link
Member Author

These days I have some free time, and I chosen to move on with this issue (one of the most requested).
I'm adjusting the style references in order to get ready to implement multiple Themes.
As a start, to test the code, I started to implement the following Theme:

Screenshot_20191227-165302_GPS Logger_S

First tests show a good readability even in sunlight.
Suggestion and ideas are really appreciated, specially about the Tracklist's Cards!

@GrazianoCapelli
Copy link
Member Author

With the commit 5fbcc1b the code and the Styles are ready for the implementation of the second Theme.

A draft of Styles and Colors (used for coding and test the Light Theme) are included.
if someone wants to test the Light Theme it and to play with the Light Color Scheme, he can easily enable it by opening AndroidManifest.xml and modifying the following two android:theme lines:

<application
    ...
    android:theme="@style/MyMaterialTheme_Light"
    ...
    <activity android:name=".SettingsActivity"
        android:theme="@style/MySettingsTheme_Light"
        ...
    </activity>
    ...
</application>

The next phase consists on the implementation of the Preference and the code for the run-time switch.
This is - of course - a good time to post here Suggestions, Mock-ups and ideas!
For example, the tracklist now is like the image below:

photo_2019-12-29_21-21-00_s

It needs yet some care!

@GrazianoCapelli
Copy link
Member Author

A SwitchPreference has been added (Light colored Theme).
Now the theme can be changed during the App usage:

photo_2019-12-30_17-18-50_s

It's time to focus on the Tracklist, in order to find a good Design.

@GrazianoCapelli
Copy link
Member Author

Tracklist after the last commit:

Screenshot_20200102-215332_GPS Logger_s

It can surely be better, but it is acceptable for me as first instance.
We can continue the test phase.
Of course ideas, mock-ups, suggestions are welcome!

@GrazianoCapelli GrazianoCapelli changed the title Implement a "Day Mode" theme Add a Light colored Theme Jan 3, 2020
@GrazianoCapelli
Copy link
Member Author

Tracklist refined.
For me is quite good, also for the release.

Screenshot_20200108-213252_GPS Logger_S

I'm not 100% sure about the colour of the selected tracks...

@GrazianoCapelli
Copy link
Member Author

GrazianoCapelli commented Jan 20, 2020

After some commits, I think we reached a good result with the Light Theme.
We pushed the 3 Strings related to the Setting on Crowdin.
We chosen to implement a ListPreference instead of a Switch because in a future release we can easily add the possibility to follow the System Settings.

If You have any Suggestion, please consider as a start the Screenshot here below:

72715682-37b25a00-3b71-11ea-9072-ebb96c16f005_base3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is / would be a new feature for the App
Projects
None yet
Development

No branches or pull requests

1 participant