Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node v20 #40

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Support Node v20 #40

merged 1 commit into from
Oct 10, 2023

Conversation

chohner
Copy link
Contributor

@chohner chohner commented Aug 27, 2023

After strapi/strapi#16557 (released in strapi v4.12.1), v20 is officially supported. There isn't anything in this package to not warrant supporting v20 afaik.

I left the lower bound in tact to keep supporting old versions

@rafant97
Copy link

rafant97 commented Oct 9, 2023

Yes, i tried to deploy my strapi project with this plugin but it gives me an error about the node version. It doesn´t support the 20 version

@chohner
Copy link
Contributor Author

chohner commented Oct 10, 2023

@Barelydead anything I can do to get this merged? :)

@Barelydead
Copy link
Owner

I'll make a new release with when i have some time

@Barelydead Barelydead merged commit 1175a82 into Barelydead:main Oct 10, 2023
@chohner chohner deleted the patch-2 branch October 10, 2023 09:55
@chohner
Copy link
Contributor Author

chohner commented Oct 10, 2023

I'll make a new release with when i have some time

Great, thanks! Maybe a few other PRs are also worth merging before :)

@rafant97
Copy link

When i try to deploy my project i have this error:

"error strapi-plugin-populate-deep@3.0.0: The engine "node" is incompatible with this module. Expected version ">=14.19.1 <=18.x.x". Got "20.8.0""

I hope it will be fixed soon 😅

@rafant97
Copy link

Hello, i still have the shame error message to deploy my project. I realised my package.json is different than the new merge. This is my package.json:
https://github.com/rafant97/portfolio-web/blob/main/package.json

Is there anything that i am missing about the plugin?

@chohner
Copy link
Contributor Author

chohner commented Oct 13, 2023

Hello, i still have the shame error message to deploy my project. I realised my package.json is different than the new merge. This is my package.json: https://github.com/rafant97/portfolio-web/blob/main/package.json

Is there anything that i am missing about the plugin?

afaik there has not been a release yet

@rafant97
Copy link

Does anyone knows if it was updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants