SWI-2832 Migrate to OpenAPI Generator v7.0.0
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed TN lookup Tests in this commit
v7.0.0v7.0.0
v7.0.0v7.0.0
ckoegel
reviewed
Sep 6, 2023
|
|
||
| self.assertApiException(context, UnauthorizedException, 401) | ||
|
|
||
| def test_create_call_forbidden(self) -> None: | ||
| """Validate a forbidden (403) request | ||
| """ | ||
| with self.assertRaises(ForbiddenException) as context: | ||
| self.forbidden_api_instance.create_call(BW_ACCOUNT_ID, self.testCallBody, _return_http_data_only=False) | ||
| self.forbidden_api_instance.create_call(BW_ACCOUNT_ID, self.testCallBody) | ||
|
|
||
| self.assertApiException(context, ForbiddenException, 403) | ||
|
|
||
|
|
||
| def test_get_call_state(self): |
There was a problem hiding this comment.
do we need to add logic here to deal with the high latency for this operation?
There was a problem hiding this comment.
all the tests are passing as is so i say leave it for now 🤷
There was a problem hiding this comment.
We want to migrate to mocking anyways right?
There was a problem hiding this comment.
We want to migrate to mocking anyways right?
|
@noahg1 the |
hamermike
requested changes
Sep 13, 2023
juliajanu
reviewed
Sep 13, 2023
test/test_account_statistics.py
Outdated
There was a problem hiding this comment.
Why are all of these new unit test stubs added? For example: test_account_statistics.py exists here and in test/unit.
hamermike
previously approved these changes
Sep 13, 2023
hamermike
approved these changes
Sep 13, 2023
juliajanu
approved these changes
Sep 13, 2023
matthewkmartin
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.