SWI-1670: Refactoring .NET Verbs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrice6713
requested changes
Aug 8, 2023
Comment on lines
36
to
42
| public string BridgeCompleteFallbackUrl; | ||
|
|
||
| /// <summary> | ||
| /// (optional) The HTTP method to use to deliver the Bridge Complete webhook to bridgeCompleteFallbackUrl. | ||
| /// </summary> | ||
| [XmlAttribute("bridgeCompleteFallbackMethod")] | ||
| public string BridgeCompleteFallbackMethod; |
There was a problem hiding this comment.
do these need the { get; set; } defined?
| public string BridgeTargetCompleteFallbackMethod; | ||
|
|
||
| /// <summary> | ||
| /// Username for basic auth on the bridgeCompleteUrl & bridgeTargetCompleteUrl. |
There was a problem hiding this comment.
Suggested change
| /// Username for basic auth on the bridgeCompleteUrl & bridgeTargetCompleteUrl. | |
| /// (optional) Username for basic auth on the bridgeCompleteUrl & bridgeTargetCompleteUrl. |
| public string Username { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Password for basic auth on the bridgeCompleteUrl & bridgeTargetCompleteUrl. |
There was a problem hiding this comment.
Suggested change
| /// Password for basic auth on the bridgeCompleteUrl & bridgeTargetCompleteUrl. | |
| /// (optional) Password for basic auth on the bridgeCompleteUrl & bridgeTargetCompleteUrl. |
Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com>
ajrice6713
approved these changes
Aug 8, 2023
juliajanu
added a commit
that referenced
this pull request
Dec 22, 2023
* Remove all previous SDK remnants * Add bandwidth.json spec * Generate SDK using Openapi Generator CLI ```openapi-generator-cli generate -g csharp-netcore -i bandwidth.json -c openapi-config.yml``` * Add empty integration test files * add .vscode to gitignore * Remove vscode files * SWI-1670: Refactoring .NET Verbs (#69) * SWI-1645: adding Root BXML verbs * SWI-1645: Update test file name * SWI-1645: Update test file name one more time * SWI-1645: Update versions of actions used in test workflow * SWI-1645: Update runner version * SWI-1645: Update action versions in deploy action * SWI-1670: Revert changes to old BXML * SWI-1670: Updated serialization library used * SWI-1670: Adding new Verbs * SWI-1670: Updating gitignore * SWI-1670: Updating verbs * SWI-1670: Update Conference file to be uppercase * Update .github/workflows/deploy.yml Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com> * SWI-1670: Fixing comments and adding getters and setters where they were missing --------- Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com> * SWI-3245: Write Tests for the BXML Verbs (#70) * SWI-3245: Adding test files for verbs * SWI-3245: Adding test files for verbs for real * SWI-3245: all tests are written * SWI-3245: Adding DS_store to gitignore * SWI-3245: Add missing package * SWI-3245: Update netcore framework version used * SWI-3245: Fixing tests * SWI-3245: Updating tests again * SWI-3245: Update tests * SWI-3245: Add space to expected string for verbs with no attributes & context * SWI-3245: Update Tests to Target .NET 6 & 7 * SWI-1687: [.NET] Unit Tests for API Models (#71) * SWI-1687: Updating OpenAPI generated tests * SW-1687: finished up tests * SWI-1687: Formatting changes * SWI:1687: Update config files * SWI-1687: Remove additionalProperties tag in config file * Update openapi-config.yml Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com> * SWI-1687: I wanted it in alphabetical order --------- Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com> * SWI-3341: Update to OpenAPI Generator 7.0.0 (#72) * SWI-3342: generated with newest API spec file and added a new test (#73) * SWI-1680: [.NET] Unit Tests for APIs (#74) * SWI-3342: generated with newest API spec file and added a new test * SWI-1680: Added API Unit tests * SWI-1680: Update Test csproj file * SWI-1680: Trying to fix tests with streams * SWI-1632: [.NET] API Integration Tests (#75) * SWI-1632: Working on API integration tests * SWI-1632: Finished integration tests * SWI-1632: Added environment variables to workflows * SWI-1632: Added forbidden user & pass to workflows * SWI-1632: Added rate limit test * SWI-1632: Updating request to number * SWI-1632: Trying to get media tests to work * SWI-1632: General reformatting * SWI-1694: Update test and deployment workflows (#76) * SWI-1694: Updated test workflows * SWI-1694: Adding feature branch to nightly test * SWI-1694: Update deploy workflow * SWI-1694: Update deploy to handle pre-releases * SWI-1694: Update deployment workflow (#77) * SWI-1694: Updated test workflows * SWI-1694: Adding feature branch to nightly test * SWI-1694: Update deploy workflow * SWI-1694: Update deploy to handle pre-releases * SWI-1694: fix conditional statement * SWI-1694: Updated regex * SWI-1694: Update CODEOWNERS * SWI-1694: Updating echo command to be nicer * SWI-1695: updating the regex again (#78) * SWI-1695: Fix regex for new releases (#79) * SWI-1695: updating the regex again * SWI-1695: updating the regex again pt.2 * SWI-1695: removed comment * SWI-1695: Update quotes * SWI-1695: Adding a missing environment variable (#80) * SWI-1695: updating the regex again * SWI-1695: updating the regex again pt.2 * SWI-1695: removed comment * SWI-1695: Update quotes * SWI-1695: Add missing environment variable * Update deploy.yml * SWI-1695: Updated env vars * SWI-1696: Finishing touches before beta release (#81) * SWI-1696: Update csproj and openapi ignore files * Update src/Bandwidth.Standard/Bandwidth.Standard.csproj Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com> * Update src/Bandwidth.Standard/Bandwidth.Standard.csproj Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com> --------- Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com> * SWI-3915: Regenerate C# SDK and add tests for new endpoint (#82) * SWI-3915: Regenerated SDK & added tests for new endpoint * SWI-3915: Uncomment [Fact] * SWI-3915: Fix list calls api test * SWI-3933: Regenerated with version 7.1.0 (#83) * SWI-3945: Adding "update-sdk" workflow (#84) * SWI-3945: Add an update SDK workflow * Update .github/workflows/update-sdk.yml Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com> --------- Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com> * SWI-4077: Remove the update-sdk workflow (#90) --------- Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com> Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran openapi generate and created new root BXML verbs: Root, Bxml, Response, IVerb. Also refactored the main BXML verbs. These changes are found in src/Bandwidth.Standard/Model/Bxml/ and src/Bandwidth.Standard/Model/Bxml/Verbs respectively.