Skip to content

Commit

Permalink
Remove GITHUB_RUN_ID and replace with GUID (#39)
Browse files Browse the repository at this point in the history
  • Loading branch information
hamermike authored Oct 12, 2021
1 parent 4aea40c commit 613bcca
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion Bandwidth.StandardTests/Messaging/MediaManagementTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public MediaManagementTests()
public async Task UploadAndDownloadMedia()
{
var accountId = TestConstants.AccountId;
var mediaId = string.Concat(TestConstants.RunId, "text-media-id");
var mediaId = $"text-media-id-{Guid.NewGuid()}";

var content = "Hello world";
var contentType = "text/plain";
Expand Down
3 changes: 0 additions & 3 deletions Bandwidth.StandardTests/Utilities/TestConstants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ public static class TestConstants
// The publicly available base callback URL.
public static readonly string BaseCallbackUrl = System.Environment.GetEnvironmentVariable("BASE_CALLBACK_URL");

// Unique run id used to generate unique test ids.
public static readonly string RunId = System.Environment.GetEnvironmentVariable("GITHUB_RUN_ID") ?? "local-run-id";

// Milliseconds of time to pause between voice requests.
public static readonly int Timeout = 500;
}
Expand Down

0 comments on commit 613bcca

Please sign in to comment.