forked from logseq/logseq
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/db #66
Open
Bad3r
wants to merge
6,127
commits into
Bad3r:master
Choose a base branch
from
logseq:feat/db
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/db #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c12d03
to
6244543
Compare
9a2e078
to
458ac81
Compare
ec41c85
to
b66a3b8
Compare
Refactor: custom react hooks
There was no UI indicator that the config applied at property or block level so updated wording and moved it down to other node-level actions
instead of confusing :build/block. Also improved related tests, simplified import steps, added some missing sqlite.build docs, and fixed :build/uuid not working for some existing journals.
when uuids are kept and when journals are created. Also removed :logseq.class/Journal from export as its needless noise
Use worker db to get full results. Using render db only returned what had been lazy loaded
Also fix get-classes-parents only returning first tag's parents
for any user. Better to get feedback early and iterate. Easy to reverse this as needed
… compatible with nbb
refactor: update schema-version format
* wip: view group by * feat: view group by rendering * enhance: use current group's value when creating new block * enhance: add icons for view layouts * fix: group rows selection * fix: property type migration from #11695 * refactor: use namespaced keyword for block export instead of confusing :build/block. Also improved related tests, simplified import steps, added some missing sqlite.build docs, and fixed :build/uuid not working for some existing journals. * fix: remove export+imports invalid when uuids are kept and when journals are created. Also removed :logseq.class/Journal from export as its needless noise * fix(ux): incorrect behavior for the sub menu content within the table header popup * fix: group rows delete * fix: lint * fix: group block delete * fix: bump version * fix: group by titles not correct for :checkbox Also enable group-by for :date as they just work * fix: disable nonsensical and unreadable groupings for :many properties * fix: grouping not working for :default property type and sometimes :number or :url. Was grouping by entity and not what user reads. If there are 2 :default values with 'text ha', this seemed buggy * fix: icons not showing for grouping by status --------- Co-authored-by: Gabriel Horner <gabriel@logseq.com> Co-authored-by: charlie <xyhp915@qq.com>
Also forgot to commit better binding name for #11731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.