Bugfix: version number wasn't appearing in container builds #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
After switching to using a pyproject.toml, boardwalk and boardwalkd where no longer outputting the correct package version number specifically when built as a distribution package. It was appearing as
0.0.0in on the CLI and in the UI. After some head-scratching, I realized that this issue resolves if arguments are passed tobuildexplicitly. I'm assuming this might be a bug in setuptools, but I'm not entirely certain. I tried using the latest version and the situation didn't resolve.How was this tested?
Tested by building and running boardwalk as a container locally, which uses the dist package
Checklist