Viewer: Allow environment texture and skybox to be set separately (and a couple other small changes) #15994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is to allow the environment texture and the skybox to be configured separately (this has come up multiple times, including in the forum. To try to keep this simple,
Viewer.loadEnvironment
now has an options object where you can specify whether the "environment" should be used for lighting or skybox or both. On the html element level, theenvironment
attribute behaves the same as before (sets both the env texture and the skybox), but there are also nowenvironment-lighting
andenvironment-skybox
attributes if you want to set them separately. This makesenvironment
essentially a shorthand, somewhat likepadding
relative topadding-top
,padding-bottom
, etc.The other changes included in this PR are:
surface
type hotspot will almost certainly have moved by the time the camera finishes its interpolation. This change was based on feedback from @PatrickRyanMS.@internal
so they don't show up in the API docs.