Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of patch post release of v0.2.3 #101

Merged
merged 19 commits into from
Feb 26, 2025
Merged

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Feb 25, 2025

This is an assorted collection of patches pose release of v0.2.3

  • Reconnect the movementStarted and movementFinished signals between DriveControlWidget and DriveDesktopController so the motion group configuration widgets are properly disabled during the movement.
  • Disable the control mode selection box during drive movement.
  • Give the central motion group config widgets a fixed with so they do NOT stretch during a resize.
  • Have the the plot in MGWidget retain its size when hidden (prevents stretching of other widgets).
  • Have AxisControlWidget.target_position return None if the text box contains an empty string. This prevents a ValueError from being raised before the widget is fully initialized.
  • Update GearValidButton to allow for more external control of setting icon and fixed sizes.
  • Created QTAIconLabel class to streamline placing icons from qtawesome.
  • If the transformer is changed from a valid one to and invalid transform, stop updating displays that require pinging the motor for position. If you do not do this, then a ValueError will be raised since there is no transform to convert between the drive coordinates and motion space coordinates.
  • Add a simple legend to the MGWidget central builder layout.
  • Add a legend to the display generated by MotionSpaceDisplay.

…iveControlWidget and DriveDesktopController so config widgets and properly disabled during movement
@rocco8773 rocco8773 added bug Something isn't working Component | GUI code touching the GUI functionality labels Feb 25, 2025
…he controls via executing _validate_motion_group()
…rom MGWidget._validate_drive() ... leave this for _validate_motion_group()
@rocco8773 rocco8773 merged commit 8c95212 into main Feb 26, 2025
8 checks passed
@rocco8773 rocco8773 deleted the patches_to_v0.2.3 branch February 26, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component | GUI code touching the GUI functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant