-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of patch post release of v0.2.3
#101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iveControlWidget and DriveDesktopController so config widgets and properly disabled during movement
…he controls via executing _validate_motion_group()
…stretch during resize
…ox has an empty string
…rom MGWidget._validate_drive() ... leave this for _validate_motion_group()
…n MGWidget._validate_motion_group()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an assorted collection of patches pose release of
v0.2.3
movementStarted
andmovementFinished
signals betweenDriveControlWidget
andDriveDesktopController
so the motion group configuration widgets are properly disabled during the movement.MGWidget
retain its size when hidden (prevents stretching of other widgets).AxisControlWidget.target_position
returnNone
if the text box contains an empty string. This prevents aValueError
from being raised before the widget is fully initialized.GearValidButton
to allow for more external control of setting icon and fixed sizes.QTAIconLabel
class to streamline placing icons fromqtawesome
.ValueError
will be raised since there is no transform to convert between the drive coordinates and motion space coordinates.MGWidget
central builder layout.MotionSpaceDisplay
.