Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Define critical tests from Bitcoin / Zcash #19

Open
ch4ot1c opened this issue Jun 27, 2018 · 2 comments
Open

[tests] Define critical tests from Bitcoin / Zcash #19

ch4ot1c opened this issue Jun 27, 2018 · 2 comments
Assignees
@ch4ot1c
Labels
Brainstorming Consensus Tests

Comments

@ch4ot1c
Copy link
Contributor

ch4ot1c commented Jun 27, 2018 •
edited by BlueSilver22
Loading

The qa/ directory https://github.com/zcash/zcash needs to be added and integrated. test/ is the directory used by this repo and Bitcoin for tests.

So far, gtest tests from zcash have been added: https://github.com/BTCPrivate/BTCP-Rebase/blob/master/src/Makefile.am#L647

Let's do this after we have our first few Travis tests working.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@ch4ot1c
Copy link
Contributor Author

ch4ot1c commented Jun 27, 2018

I see several have been added here 8e04b9d, but I want to be sure we aren't missing any

@ch4ot1c ch4ot1c added the Tests label Jul 21, 2018
@ch4ot1c
Copy link
Contributor Author

ch4ot1c commented Jul 21, 2018

We should define a subset of initial set of tests from Bitcoin to get passing. Consensus codepaths should probably be first.

@ch4ot1c ch4ot1c changed the title BTCP/Zcash tests [tests] Define critical tests from Bitcoin / Zcash Jul 21, 2018
@ch4ot1c ch4ot1c self-assigned this Jul 31, 2018
@ch4ot1c ch4ot1c mentioned this issue Aug 1, 2018
Merged
ch4ot1c pushed a commit to ch4ot1c/BTCP-Rebase that referenced this issue Oct 2, 2018
Squashed 'src/leveldb/' changes from 64052c76c5..524b7e36a8
ec749b1 
524b7e36a8 Merge BTCPrivate#19: Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems
4874cb8d3e Increase maximum number of read-only mmap()s used from 1000 to 4096 on 64 bit systems.

git-subtree-dir: src/leveldb
git-subtree-split: 524b7e36a8e3bce6fcbcd1b5df09024283f325ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch4ot1c ch4ot1c

Labels
Brainstorming Consensus Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ch4ot1c