Make polynomials depend on time #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Tests are WIP.
# Conflicts: # napytau/core/chi.py # napytau/core/core.py # napytau/core/delta_tau.py # napytau/core/polynomials.py # napytau/core/tau.py # tests/core/polynomials_test.py
…nomial calculation.
Benedikt-Brunner
requested changes
Jan 28, 2025
napytau/core/polynomials.py
Outdated
| dataset.get_relative_velocity().value.get_velocity() | ||
| * sp.constants.speed_of_light | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| def evaluate_polynomial_at_measuring_distances( |
There was a problem hiding this comment.
Either we also adjust the function name or we don't adjust the comment
Benedikt-Brunner
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the direct use of distances in polynomials.py to the use of times, calculated from the distances and the velocity relative to the speed of light.$t_i$ , which is the time, instead of i, which would be the distance.
It was curcial to change this, since the underlying formula is in respect to
PR checklist
Closes/Fixes/Related to