-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client] [WSL] Extend detection. #2568
Conversation
Move WSL detection to get_host_info(). Enumerate available WSLs from registry. Add wslapi library loading. Add support of multiple installed wsl distros detection. Detect only installed and configured distros. Add extra information parse. Add wslinfo files to save and parse wsl info. Add dont_use_wsl param to cc_config. Add missed hostinfo_wsl.cpp when building win client using gcc. Fix small issues. Small refactoring. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@davidpanderson, @ChristianBeer, @RichardHaselgrove, @JuhaSointusalo, @TheAspens |
It seems that you are setting XML tag name from distro name. That's interesting idea but possibly bad one if you ever want to process the XML with something other than BOINC's XML parser. I would have the distro name in it's own element, say |
@JuhaSointusalo, ok, I'll fix this |
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Fixed |
This all looks fine to me, though I'm unable to test it. |
Looks good. I'll merge. Thanks for doing this. |
Now we have a merged version, I was able to build a test version (VS 2013) and try it. No errors, and
Unfortunately, I think GPUGrid have (temporarily?) abandoned their attempts to get Quantum Chemistry running under WSL, so full testing will have to wait. But good so far. And under Windows 7, it simply says |
@AenBleidd: small bug Running the WSL-enabled client under Windows 7, so no WSL available and none detected - all good. Client writes extra line into cc_config.xml Patch in #2581 |
Move WSL detection to get_host_info().
Enumerate available WSLs from registry.
Add wslapi library loading.
Add support of multiple installed wsl distros detection.
Detect only installed and configured distros.
Add extra information parse.
Add wslinfo files to save and parse wsl info.
Add dont_use_wsl param to cc_config.
Add missed hostinfo_wsl.cpp when building win client using gcc.
Fix small issues.
Small refactoring.
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com