CI: 4 Cores Linux/Win, 3 Cores macOS #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WeiqunZhang I am surprised that OpenMPI does not find the 4 cores in CI... wondering if it actually has four in these workflows? |
Increase build and test parallelism according to new increased core limits on public GH hosted runners.
Different initialization seeds with more MPI ranks. Increase tolerances until they pass.
|
|
Use the usually empty `MPIEXEC_POSTFLAGS` for this: https://cmake.org/cmake/help/latest/module/FindMPI.html#variables-for-using-mpi
Before
After
|
|
@WeiqunZhang Looks like CI actually gets slower using more cores. I think the reason for that is that we likely only get 2 physical cores when they say "4 cores", and they mean actually 4 vcores, so 2 cores w/ 2x HT or so... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase build and test parallelism according to new increased core limits on public GH hosted runners.