-
Notifications
You must be signed in to change notification settings - Fork 44
Adopt PSR-2 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt PSR-2 #8
Conversation
Will continue work on this tomorrow. FYI, tests would defintely help simplify the changes made here 😉 |
Ha, yeah, no doubt. It's a great regret of mind that we didn't TDD this. Thanks for all your efforts here! |
Ready for review! Take your time with this one, there's also a few places I ended up simplifying logic. Mainly constructions like this: if ($condition) {
return $foo;
} else {
return $bar;
} which I changed to: if ($condition) {
return $foo;
}
return $bar; |
Dude, amazing. Thanks! My next steps are gonna start a Laravel 5.4 branch ( #6 ), probably next week, and create some integration tests first, as part of that. Then, with that done, I'll merge your PR in and see if the tests still pass. Then address L5.4 support. |
👍 Sounds good! |
Project looking promising !! |
Will resolve conflicts later today 🙂 |
Sorry bout that, was pretty trivial so I did it ;) |
This PR is the working branch to PSR-2-ify the codebase of this project, as discussed in #7.