Skip to content

Adopt PSR-2 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 24, 2017
Merged

Adopt PSR-2 #8

merged 21 commits into from
Mar 24, 2017

Conversation

svenluijten
Copy link
Contributor

This PR is the working branch to PSR-2-ify the codebase of this project, as discussed in #7.

@svenluijten
Copy link
Contributor Author

Will continue work on this tomorrow.

FYI, tests would defintely help simplify the changes made here 😉

@weotch
Copy link
Member

weotch commented Mar 16, 2017

Ha, yeah, no doubt. It's a great regret of mind that we didn't TDD this.

Thanks for all your efforts here!

@svenluijten svenluijten changed the title [DO NOT MERGE] Adopt PSR-2 Adopt PSR-2 Mar 17, 2017
@svenluijten
Copy link
Contributor Author

Ready for review! Take your time with this one, there's also a few places I ended up simplifying logic. Mainly constructions like this:

if ($condition) {
    return $foo;
} else {
    return $bar;
}

which I changed to:

if ($condition) {
    return $foo;
}

return $bar;

@weotch
Copy link
Member

weotch commented Mar 17, 2017

Dude, amazing. Thanks!

My next steps are gonna start a Laravel 5.4 branch ( #6 ), probably next week, and create some integration tests first, as part of that. Then, with that done, I'll merge your PR in and see if the tests still pass. Then address L5.4 support.

@svenluijten
Copy link
Contributor Author

👍 Sounds good!

@minedun6
Copy link

Project looking promising !!
Would love to see what we can do with this ^_^.

@svenluijten
Copy link
Contributor Author

Will resolve conflicts later today 🙂

@weotch
Copy link
Member

weotch commented Mar 21, 2017

Sorry bout that, was pretty trivial so I did it ;)

@weotch weotch merged commit c019cae into BKWLD:master Mar 24, 2017
@svenluijten svenluijten deleted the adopt-psr-2-coding-standard branch March 26, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants