Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value to core properties #612

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

adecler
Copy link
Member

@adecler adecler commented Dec 12, 2024

Issues addressed by this PR

Closes #611

See issue for more details

@adecler adecler added the type:bug Error or unexpected behaviour label Dec 12, 2024
@adecler adecler self-assigned this Dec 12, 2024
@adecler
Copy link
Member Author

adecler commented Dec 12, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 12, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 255 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve 👍

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 12, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

There are 343 requests in the queue ahead of you.

@adecler adecler merged commit 0d3b6b7 into develop Dec 12, 2024
10 checks passed
@adecler adecler deleted the XML_Toolkit-#611-DefaultValuesForCoreProperties branch December 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properties like CustomData, Tags, and FragmentSet need to have a default value
2 participants