-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests for pushing GBXML files #597
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great work @Tom-Kingstone
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #595
Functional tests for the the pull action have been created that test a number of scenarios:
Test files
Changelog
Additional comments
Uses the JSON serialised BHoM objects to push to GBXML and compare.