Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GBXML DocumentBuilder from workflow for pushing Environment objects to XML #582

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Aug 23, 2023

Fixes #475

Test files available here.

I recommend pushing an Environments Model to gbXML and viewing either via Aragog or another gbXML viewer of your choice.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Aug 23, 2023
@FraserGreenroyd FraserGreenroyd requested a review from tg359 as a code owner August 23, 2023 11:25
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 23, 2023
@FraserGreenroyd FraserGreenroyd changed the title Remove GBXML DocumentBuilder from workflow for pushing Environment ob… Remove GBXML DocumentBuilder from workflow for pushing Environment objects to XML Aug 23, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check null-handling

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have confirmed satisfactory behaviour by running the provided test GH file and viewing in Aragog, works as expected without issue.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 77c2183 into develop Aug 23, 2023
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#475-DocumentBuilder branch August 23, 2023 15:34
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add protection for Shading and unassigned Panels
2 participants