Avoid copying BHoM assemblies to BHoMUpgrader folder

[pawelbaran]

Issues addressed by this PR

Closes #265

Test files

Theoretically it should be enough if versioning check passed, but I also added a super simple manual test: just build this branch => rebuild BHoM and Versioning_Toolkit => check if C:\ProgramData\BHoM\Upgrades\BHoMUpgrader73 gets populated as expected => run script from here.

Changelog

Additional comments

[adecler]

The change makes sense but there is an issue with missing dlls for MongoDB and CompilerServices.Unsafe.

This is what the ProgramData folders give us for 7.2 vs 7.3:

Running the upgrader 7.3 from the console, does indeed give me an error for missing dll:

[pawelbaran]

Running the upgrader 7.3 from the console, does indeed give me an error for missing dll:

Yeah I saw it, but thought it is OK taken versioning is always preceded by a call to LoadBHoMAssemblies(), which loads all required dependencies - that, however, I have only verified in GH and Revit.

Out of curiosity, did you call LoadBHoMAssemblies() prior to running versioning in your console app @adecler? I would argue the upgrader does not need to work as a standalone app as it only has meaning in the context of BHoM, i.e. let's remove MongoDB.Bson.dll from the upgraders to save a few MB in the installer size and ask the consumers to load BHoM before running versioning. Or is there a gap in my thinking?

[adecler]

Yes, the upgraders need to be able to work as stand alone. It worked within the BHoM only because versionWithPipe is currently set to false int the ToNew method.

[pawelbaran]

I pushed a fix @adecler - simply added the missing assemblies as dependencies to BHoMUpgrader73 project.

[adecler]

Thanks @pawelbaran, that does the trick. A bit strange that the explicit copy of dependencies is needed while it isn't in the other ones but I wouldn't loose sleep over it when there is a straightforward fix.

Final thing that might be good to do here while we have the chance: the BHoMUpgrader depends on Reflection-Engine, Serialiser_Engine, and Versioning_Engine but doesn't actually use them so it might be good to clean that up as well.

[pawelbaran]

I removed all BHoM dependencies from the upgrader now 👍

[adecler]

I removed all BHoM dependencies from the upgrader now 👍

Thanks @pawelbaran , I don't see the commit though :-P.

[pawelbaran]

Lol of course, because I did not push it before closing the machine 😃 Done now, sorry.

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 176 requests in the queue ahead of you.

[adecler]

All requested changes have been addressed. Happy to approve

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check copyright-compliance
• check ready-to-merge