Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for 7.3 milestone #264

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Changes for 7.3 milestone #264

merged 5 commits into from
Jun 26, 2024

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #263

  • Add new upgrader
  • Freeze upgrade file from previous version
  • Add new test sets for 7.2
  • Change versions in verification

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Jun 26, 2024
@IsakNaslundBh IsakNaslundBh requested a review from adecler June 26, 2024 10:58
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 26, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 26, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

There are 71 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check copyright-compliance
@BHoMBot check installer

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 26, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check core
  • check copyright-compliance
  • check installer

adecler
adecler approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on

  • Review of the code changes themselves
  • Units tests are passing
  • Bot checks are passing

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 26, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit c436b1d into develop Jun 26, 2024
5 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Versioning_Toolkit-#263-ChangesFor73Milestone branch June 26, 2024 12:32
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upgrader and test dataset for 7.3
2 participants
@IsakNaslundBh @adecler