Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Versioning for SimulationResult for LadyBugTools #227

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/LadybugTools_Toolkit#90

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Jun 8, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jun 8, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on LadybugTools_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on LadybugTools_Toolkit

Copy link

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning is now working for the LBT TK due to changes made in this PR, so happy to approve.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check copyright-compliance

There are 18 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on LadybugTools_Toolkit

@FraserGreenroyd FraserGreenroyd merged commit 472ddb1 into develop Jun 8, 2023
@FraserGreenroyd FraserGreenroyd deleted the LBT_Toolkit-#XX-ProjectChanges branch June 8, 2023 15:50
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants