Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Versioning checks to decide between running all versions or just the latest #201

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Aims to speed up Versioning checks on PRs by allowing only the latest version to be tested against, with all versions saved for overnight builds.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Sep 15, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 15, 2022
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, good to get the speed up. See slight comment on potential change though.

Leave it up to you if you want to change or not.

@@ -44,10 +44,13 @@ public static partial class Verify
/**** Test Methods ****/
/*************************************/

public static TestResult FromJsonDatasets()
public static TestResult FromJsonDatasets(bool testAll = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if this should not be defaulting to true, to keep the current behaviour, unless instructed otherwise by the caller. Will still approve and leave it up to you if you want to change this or not.

Suggested change
public static TestResult FromJsonDatasets(bool testAll = false)
public static TestResult FromJsonDatasets(bool testAll = true)

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants