-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Versioning checks to decide between running all versions or just the latest #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, good to get the speed up. See slight comment on potential change though.
Leave it up to you if you want to change or not.
@@ -44,10 +44,13 @@ public static partial class Verify | |||
/**** Test Methods ****/ | |||
/*************************************/ | |||
|
|||
public static TestResult FromJsonDatasets() | |||
public static TestResult FromJsonDatasets(bool testAll = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this should not be defaulting to true, to keep the current behaviour, unless instructed otherwise by the caller. Will still approve and leave it up to you if you want to change this or not.
public static TestResult FromJsonDatasets(bool testAll = false) | |
public static TestResult FromJsonDatasets(bool testAll = true) |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, versioning |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
1 similar comment
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Aims to speed up Versioning checks on PRs by allowing only the latest version to be tested against, with all versions saved for overnight builds.