Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoMUpgrader53: Add Converter methods for Revit_UI repo split #200

Merged

Conversation

vietle-bh
Copy link
Contributor

NOTE: Depends on

TBC

Issues addressed by this PR

Added Converter methods for Revit_UI repo split

Changelog

  • Added Converter methods for Revit_UI repo split

@vietle-bh vietle-bh self-assigned this Aug 10, 2022
@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

@vietle-bh vietle-bh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Aug 10, 2022
@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

@vietle-bh
Copy link
Contributor Author

Sorry @FraserGreenroyd , the custom converter method fixed the versioning check on my machine but not here, probably because the check here doesn't see the same branch name under Revit_UI. It sees the branch under BuroHappold_Revit_Toolkit though. Do you know why?

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 11, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 11, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 11, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

2 similar comments
@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 11, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 12, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

There are 67 requests in the queue ahead of you.

@vietle-bh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check core
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 12, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check core
  • check installer

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code review and passing tests in line with the work undertaken by @vietle-bh

@vietle-bh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 12, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 2a3917d into main Aug 12, 2022
@FraserGreenroyd FraserGreenroyd deleted the Revit_UI-#1-MigrateProjectsFromBuroHappold_Revit_Toolkit branch August 12, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants