Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3 Deployment #138

Merged
merged 4 commits into from
Sep 19, 2024
Merged

7.3 Deployment #138

merged 4 commits into from
Sep 19, 2024

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Sep 9, 2024

Copy link

bhombot-ci bot commented Sep 10, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Sep 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Sep 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on File_Toolkit

Copy link

bhombot-ci bot commented Sep 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

Copy link

bhombot-ci bot commented Sep 12, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on LadybugTools_Toolkit

Copy link

bhombot-ci bot commented Sep 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoMAnalytics_Toolkit

@IsakNaslundBh IsakNaslundBh self-assigned this Sep 12, 2024
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the functionality of DelaunayTriangulation as well as VoronoiRegions .

Would be good with a review of @enarhi or @alelom as well given the minor change in the representation methods.

@BHoMBot BHoMBot added the type:feature New capability or enhancement label Sep 12, 2024
Copy link

bhombot-ci bot commented Sep 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Sep 13, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Sep 13, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_Documentation_Tool

Copy link

bhombot-ci bot commented Sep 17, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_SecurityICT_Tool

Copy link

bhombot-ci bot commented Sep 17, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_UI

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, working as expected for various spot checked methods including the ones effected by the code change.

Copy link

bhombot-ci bot commented Sep 19, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on ETABS_Toolkit

Copy link

bhombot-ci bot commented Sep 19, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on ETABS_Toolkit

Copy link

bhombot-ci bot commented Sep 19, 2024

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit b13d40f into main Sep 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants