Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NetStandard2.0 #116

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #115

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 16, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Mar 16, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 7 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 12058730980

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix project file ref. 12058730980

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 18 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 24 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review March 16, 2023 17:29
@FraserGreenroyd FraserGreenroyd requested a review from adecler March 16, 2023 17:30
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still compiles and copies the dlls across.
Tested on a few sample scripts and still works as expected.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 14 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 9 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 34 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 31ae263 into develop Mar 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the Socket_Toolkit-#115-UpgradeToNetStandard branch March 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to .NetStandard2.0
3 participants