Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing configuration of AdapterId #53

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

svaz00
Copy link
Contributor

@svaz00 svaz00 commented Mar 16, 2023

Adds a line that sets the adapter ID to be false.

Issues addressed by this PR

Closes #52

Test files

Tested using the most recent STL Toolkit testing procedure.

@svaz00 svaz00 added the type:bug Error or unexpected behaviour label Mar 16, 2023
@svaz00 svaz00 self-assigned this Mar 16, 2023
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense and align with the issue and needs of the toolkit. Approving for merge to test via beta artefacts.

@FraserGreenroyd
Copy link

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 30 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check ready-to-merge

There are 20 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 462577b into develop Mar 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the STL_Toolkit-#52_AdapterIDfix branch March 18, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STL_Adapter: missing configuration regarding usage of AdapterId mechanism
2 participants