Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IObject compliance #40

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

FraserGreenroyd
Copy link

Issues addressed by this PR

Fixes #39

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 27, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 27, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check installer

There are 94 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See no issue with adding IObejct to the two interfaces in here. Happy to apporve

@FraserGreenroyd
Copy link
Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 7cb4f09 into develop Apr 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the Base_oM-#1509-IObjectCompliance branch April 28, 2023 14:28
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IObject compliance
2 participants