Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert .NetStandard Upgrade #36

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Revert .NetStandard Upgrade #36

merged 3 commits into from
Mar 21, 2023

Conversation

FraserGreenroyd
Copy link

Following investigation and issues in Grasshopper, reverting this change for beta until a more suitable fix can be introduced.

Fraser Greenroyd added 3 commits March 21, 2023 10:28
@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Mar 21, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Mar 21, 2023
@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review March 21, 2023 10:29
@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

adecler
adecler approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The commits reverted are matching the ones from the problematic PR.
  • The code compiles
  • The dlls are being copied over to the Assemblies folder
  • The SQL adapter is working as expected in Grasshopper

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 9787aba into develop Mar 21, 2023
@FraserGreenroyd FraserGreenroyd deleted the SQL_Toolkit-#01-RevertNetStandardUpgrade branch March 21, 2023 11:07
@FraserGreenroyd FraserGreenroyd mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@pawelbaran pawelbaran Awaiting requested review from pawelbaran

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FraserGreenroyd @adecler