Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.1 Deployment #33

Merged
merged 8 commits into from
Mar 23, 2023
Merged

6.1 Deployment #33

merged 8 commits into from
Mar 23, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd FraserGreenroyd self-requested a review March 13, 2023 18:11
@FraserGreenroyd
Copy link

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 30 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 13, 2023
@FraserGreenroyd FraserGreenroyd requested a review from adecler March 13, 2023 18:39
@FraserGreenroyd
Copy link

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 31 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 15:03.

ERROR CODE(s):

  • DF002.

DETAILS:

  • The main branch of this repository can NOT compile against the associated upstream dependencies if they are merged without this pull request. Not merging this pull request, but merging dependent repositories will result in compilation failures on the main branch of this repository..

Fraser Greenroyd added 3 commits March 21, 2023 11:07
@FraserGreenroyd
Copy link

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 21, 2023

MERGE REPORT - 2023-03-21 14:55.

DETAILS:
This pull request can be merged or not merged without impact on any of its upstream dependencies..

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
FraserGreenroyd
FraserGreenroyd approved these changes Mar 22, 2023
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code and changes are just to compliance which is fine.

I have run the beta artefact 230322 and successfully pulled data from a SQL table into Grasshopper.

I am happy for this to be deployed to the 6.1 beta.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 22, 2023
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

3 similar comments
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 75 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling

There are 281 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 377 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 446 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: documentation-compliance, ready-to-merge, installer

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: beta-installer

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 6bd7f7d into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@adecler adecler Awaiting requested review from adecler

Assignees

@bhombot-ci bhombot-ci[bot]

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FraserGreenroyd @BHoMBot @pawelbaran