-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade projects to .NetStandard2.0 #32
Upgrade projects to .NetStandard2.0 #32
Conversation
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 11931816648 |
@FraserGreenroyd I have queued up your request to fix the |
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code changes make sense
- Compile without problem
- The SQL adapter still works as expected
- Other toolkits depending on the SQL adapter like the EmbodiedCarbon toolkit still work fine
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Fixes #31
Test files
Available here - there are also other PR test scripts available here if you want to use more than just the one I've produced.