Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade projects to .NetStandard2.0 #32

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

FraserGreenroyd
Copy link

@FraserGreenroyd FraserGreenroyd commented Mar 11, 2023

Issues addressed by this PR

Fixes #31

Test files

Available here - there are also other PR test scripts available here if you want to use more than just the one I've produced.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 11, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Mar 11, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 11931816648

@FraserGreenroyd
Copy link
Author

@BHoMBot fix project file ref. 11931816648

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check versioning
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning
  • check core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Author

@BHoMBot check installer
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check null-handling
  • check serialisation

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review March 11, 2023 19:22
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes make sense
  • Compile without problem
  • The SQL adapter still works as expected
  • Other toolkits depending on the SQL adapter like the EmbodiedCarbon toolkit still work fine

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit ef8aa28 into develop Mar 14, 2023
@FraserGreenroyd FraserGreenroyd deleted the SQL_Toolkit-#31-UpgradeToNetStandard branch March 14, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to netstandard 2.0
3 participants