Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panel fragments to read #241

Merged
merged 24 commits into from
Jan 9, 2023

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Aug 26, 2021

@JosefTaylor JosefTaylor self-assigned this Aug 26, 2021
@JosefTaylor JosefTaylor added the type:feature New capability or enhancement label Aug 26, 2021
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • installer

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check copyright

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2021

@JosefTaylor sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2021

@JosefTaylor fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 3557557496

@JosefTaylor
Copy link
Contributor Author

@BHoMBot fix copyright headers ref. 3557557496

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2021

@JosefTaylor I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2021

@JosefTaylor to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@JosefTaylor JosefTaylor marked this pull request as ready for review September 9, 2021 16:08
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@JosefTaylor fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 4305558738

@JosefTaylor
Copy link
Contributor Author

@BHoMBot fix project file ref. 4305558738

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2021

@JosefTaylor I am now going to fix the CSProject compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2021

@JosefTaylor to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • project-compliance

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2021

@JosefTaylor fix requested for adding documentation punctuation.

The documentation attributes missing punctuation have been recorded as annotations on the checks tab.

I will add a full stop (.) to the end of any documentation within the changed files which does not currently end in a suitable piece of punctuation. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix documentation punctuation ref. 4314388387

@JosefTaylor
Copy link
Contributor Author

@BHoMBot fix documentation punctuation ref. 4314388387

@IsakNaslundBh IsakNaslundBh force-pushed the SAP2000_Toolkit-#43-Panel-Fragments branch from 5e725fd to 3a0fc3e Compare January 5, 2023 14:30
@enarhi
Copy link
Member

enarhi commented Jan 9, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested using the provided test script and fragments were assigned properly, pushed to SAP, and pulled as expected.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 10 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10538727097

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10538727097

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@FraserGreenroyd I have now provided a passing check on reference 10538727097 as requested.

@FraserGreenroyd
Copy link
Contributor

Although there are new files, I have dispensated the check in favour of doing a smaller, newer, surgical PR tomorrow to update copyright headers again as this PR has been open a while and already rebased once so we don't want to keep it open too much longer.

@FraserGreenroyd FraserGreenroyd merged commit b36d883 into develop Jan 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the SAP2000_Toolkit-#43-Panel-Fragments branch January 9, 2023 23:33
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAP2000_Toolkit: ReadPanel() to get additional properties as Fragment
6 participants