-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panel fragments to read #241
Conversation
@BHoMBot check installer |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check copyright |
@JosefTaylor sorry, I didn't understand. |
@BHoMBot check copyright-compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
@JosefTaylor fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix copyright headers ref. 3557557496 |
@JosefTaylor I am now going to fix the copyright compliance in accordance with the annotations previously made. |
@JosefTaylor to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
|
@JosefTaylor fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 4305558738 |
@JosefTaylor I am now going to fix the CSProject compliance in accordance with the annotations previously made. |
@JosefTaylor to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check documentation-compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
@JosefTaylor fix requested for adding documentation punctuation. The documentation attributes missing punctuation have been recorded as annotations on the checks tab. I will add a full stop ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix documentation punctuation ref. 4314388387 |
Only needed for radians to degree conversion, hard-coded instead.
5e725fd
to
3a0fc3e
Compare
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested using the provided test script and fragments were assigned properly, pushed to SAP, and pulled as expected.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is copyright-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10538727097 |
@FraserGreenroyd I have now provided a passing check on reference |
Although there are new files, I have dispensated the check in favour of doing a smaller, newer, surgical PR tomorrow to update copyright headers again as this PR has been open a while and already rebased once so we don't want to keep it open too much longer. |
NOTE: Depends on
BHoM/Revit_Toolkit#1130
Issues addressed by this PR
Closes #43
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23241-Panel-Fragments?csf=1&web=1&e=qmCvdW
Changelog
Additional comments