Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FamilyInstance_WorkPlaneBased - fixed direction for null orientation value #1515

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented Oct 24, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #

Fixed direction value for placing hosted elements on line elements (walls, ducts, pipes) if input orientation is null.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Oct 24, 2024
@michal-pekacki michal-pekacki self-assigned this Oct 24, 2024
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, thanks @michal-pekacki

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Oct 25, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 30, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 12 requests in the queue ahead of you.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 30, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

There are 17 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 30, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 27 requests in the queue ahead of you.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 30, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

There are 88 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 5e27bee into develop Oct 31, 2024
11 checks passed
@pawelbaran pawelbaran deleted the Revit_Prototypes-#1023-PlaceElementsFeatures branch October 31, 2024 08:30
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants