Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family library Create method tweaked to scrape type names from .txt file #1514

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #1513

Test files

On SharePoint - download the family together with .txt, then update the script to point at the folder containing them, check if all family types are scraped.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Oct 23, 2024
@pawelbaran pawelbaran self-assigned this Oct 23, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Oct 24, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check installer

@ssiimmoonnee
Copy link

Tested in Revit 2022. It works for me.

Copy link

@ssiimmoonnee ssiimmoonnee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Revit 2022. Works fine for me!

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Oct 25, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Oct 25, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 25, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

@pawelbaran pawelbaran merged commit 2b0c929 into develop Oct 25, 2024
11 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1513-ScrapeTxtInFamilyLibrary branch October 25, 2024 06:37
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Family library scrapes types only from the .rfa file, not .txt
2 participants