Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the external curve loop query to its own method #1497

Merged

Conversation

vietle-bh
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1496

Extracted the external curve loop query to its own method

Test files

I simply cut & pasted the relevant code to a new file, so hopefully just code review will be enough!

Changelog

Additional comments

@vietle-bh vietle-bh added the type:feature New capability or enhancement label Aug 8, 2024
@vietle-bh vietle-bh self-assigned this Aug 8, 2024
@vietle-bh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check project-compliance
@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 8, 2024

@vietle-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation
  • check project-compliance
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@vietle-bh vietle-bh requested a review from pawelbaran August 8, 2024 16:35
@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 8, 2024

@vietle-bh to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 11 requests in the queue ahead of you.

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 9, 2024

@vietle-bh to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 14 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Aug 9, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

1 similar comment
Copy link

bhombot-ci bot commented Aug 9, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve the refactor 👍

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 13, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 59 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit eddffc7 into develop Aug 14, 2024
12 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1496-ExtractExternalCurveLoopMethod branch August 14, 2024 07:43
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
Development

Successfully merging this pull request may close these issues.

Extract the logic for finding a face's main CurveLoop
2 participants