-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the external curve loop query to its own method #1497
Extract the external curve loop query to its own method #1497
Conversation
@vietle-bh to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@vietle-bh to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@vietle-bh to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
The check |
1 similar comment
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense, happy to approve the refactor 👍
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 59 requests in the queue ahead of you. |
NOTE: Depends on
Issues addressed by this PR
Closes #1496
Extracted the external curve loop query to its own method
Test files
I simply cut & pasted the relevant code to a new file, so hopefully just code review will be enough!
Changelog
Additional comments