Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangulation factor for Medium mesh quality changed from 0.5 to 0.3 #1468

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #1439

Test files

Changelog

Additional comments

Sensitivity study and discussion available under #1439

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Apr 2, 2024
@pawelbaran pawelbaran self-assigned this Apr 2, 2024
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion in #1439 captures this change nicely, approving based on code review to unblock future work in this area.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Apr 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 2, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 2, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 16 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 2, 2024

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 23337294228

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 23337294228

Copy link

bhombot-ci bot commented Apr 2, 2024

@FraserGreenroyd I have now provided a passing check on reference 23337294228 as requested.

@FraserGreenroyd FraserGreenroyd merged commit c5daf29 into develop Apr 2, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-#1439-MediumMeshQuality branch April 2, 2024 09:41
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Medium' mesh quality
2 participants