Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CenterPoint and Bounds methods #1387

Merged
merged 10 commits into from
Jul 31, 2023

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented Jul 13, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #1386

  • Bounds of the outlines method added
  • CenterPoint of the outline method added

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Jul 13, 2023
@michal-pekacki michal-pekacki added this to the BHoM 6.3 β MVP milestone Jul 13, 2023
@michal-pekacki michal-pekacki self-assigned this Jul 13, 2023
Revit_Core_Engine/Query/Bounds.cs Show resolved Hide resolved
Revit_Core_Engine/Query/CenterPoint.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/AlignOutlines.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/AlignOutlines.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/AlignOutlines.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/AlignOutlines.cs Outdated Show resolved Hide resolved
@michal-pekacki michal-pekacki requested a review from vietle-bh July 17, 2023 10:26
Revit_Core_Engine/Query/AlignOutlines.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/Bounds.cs Show resolved Hide resolved
Revit_Core_Engine/Query/AlignOutlines.cs Outdated Show resolved Hide resolved
Revit_oM/Enums/OutlineAlignment.cs Outdated Show resolved Hide resolved
@michal-pekacki michal-pekacki changed the title Add AlignOutlines Add CenterPoint and Bounds methods Jul 24, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last bit from my side 👍

Revit_Core_Engine/Query/Bounds.cs Show resolved Hide resolved
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 27, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 273 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code makes full sense to me now, thanks @michal-pekacki 👍

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 54 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

There are 88 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 5e5bfef into develop Jul 31, 2023
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1386-AlignViewports branch July 31, 2023 13:01
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align viewports in outline
3 participants