Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about nonplanar faces added when querying panel surfaces #1384

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes part of #1287

Test files

Run the standard panel pull procedure and check the culprit highlighted in #1287.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jun 28, 2023
@pawelbaran pawelbaran self-assigned this Jun 28, 2023
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are sufficient and make sense from code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit f125301 into develop Jul 6, 2023
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-#1287-NonPlanarFaceMessages branch July 6, 2023 13:40
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants